Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calculated template and save it for debugging #441

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Use calculated template and save it for debugging #441

merged 2 commits into from
Jun 25, 2024

Conversation

jsturtevant
Copy link
Contributor

After #430, the template was hard coded instead of using the calculated value. We also were not copying the file to the logs for debugging purposes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2024
@jsturtevant
Copy link
Contributor Author

This fixes the failing GMSA tests on https://testgrid.k8s.io/sig-windows-master-release#capz-windows-master-serial-slow

@jsturtevant
Copy link
Contributor Author

/test ls

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test pull-e2e-capz-validate-pr-templates
  • /test pull-e2e-capz-windows-2022-extension
  • /test pull-e2e-capz-windows-2022-extension-gmsa
  • /test pull-e2e-run-capz-sh-windows-2022-hyperv

Use /test all to run the following jobs that were automatically triggered:

  • pull-e2e-capz-windows-2022-extension

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

looks like it might need the fix from b55c971, not sure why sometimes it passes

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

docker hub was down yesterday when I ran these tests

/retest

@jsturtevant
Copy link
Contributor Author

/assign @marosset @aravindhp

marosset
marosset approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dd4f6bf into kubernetes-sigs:master Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

Assignees

@aravindhp aravindhp

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsturtevant @k8s-ci-robot @marosset @aravindhp